[Marble-devel] Re: Review Request: Configuration dialog for the Overview Map plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6298/#review9568
-----------------------------------------------------------


No, there's still a problem with regard to the initial size:
The original size and position of the float item gets passed in the ctor:

    explicit OverviewMap( const QPointF &point = QPointF( 10.5, 10.5 ),
                          const QSizeF &size = QSizeF( 166.0, 86.0 ) );

This gets passed on in the implementation:

OverviewMap::OverviewMap( const QPointF &point, const QSizeF &size )
    : AbstractFloatItem( point, size ),


If I start Marble after deleting the configuration file I still get the 200x100 map which is not what I would expect and what we need. I would expect that if there is no prior configuration setting the actual size of the item gets used. Instead the current code enforces a 200x100 size.
I think what could to be done to fix this properly is this:
Inside the ctor a member

m_defaultSize = size;

gets assigned. This value only gets used for the case where the "Reset" button is pressed. For all other cases the current size of the item must not be changed except when the user explicitely changes (or resets) it in the configuration dialog.

  


- Torsten


On 2011-01-07 16:38:50, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6298/
> -----------------------------------------------------------
> 
> (Updated 2011-01-07 16:38:50)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds a configuration dialog to the overview map plugin.
> GCI-task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129434290944?s=0
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/CMakeLists.txt 1212464 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h 1212464 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1212464 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMapConfigWidget.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6298/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110107/b36141c3/attachment.htm