<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6298/">http://svn.reviewboard.kde.org/r/6298/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, there's still a problem with regard to the initial size:
The original size and position of the float item gets passed in the ctor:
explicit OverviewMap( const QPointF &point = QPointF( 10.5, 10.5 ),
const QSizeF &size = QSizeF( 166.0, 86.0 ) );
This gets passed on in the implementation:
OverviewMap::OverviewMap( const QPointF &point, const QSizeF &size )
: AbstractFloatItem( point, size ),
If I start Marble after deleting the configuration file I still get the 200x100 map which is not what I would expect and what we need. I would expect that if there is no prior configuration setting the actual size of the item gets used. Instead the current code enforces a 200x100 size.
I think what could to be done to fix this properly is this:
Inside the ctor a member
m_defaultSize = size;
gets assigned. This value only gets used for the case where the "Reset" button is pressed. For all other cases the current size of the item must not be changed except when the user explicitely changes (or resets) it in the configuration dialog.
</pre>
<br />
<p>- Torsten</p>
<br />
<p>On January 7th, 2011, 4:38 p.m., Daniel Marth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Daniel Marth.</div>
<p style="color: grey;"><i>Updated 2011-01-07 16:38:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a configuration dialog to the overview map plugin.
GCI-task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129434290944?s=0</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/CMakeLists.txt <span style="color: grey">(1212464)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h <span style="color: grey">(1212464)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(1212464)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMapConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>