[Marble-devel] Review Request: have GeometryLayer and PlacemarkLayout connect() themselves

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103167/#review8699
-----------------------------------------------------------



src/lib/GeoDataTreeModel.h
<http://git.reviewboard.kde.org/r/103167/#comment7325>

    The solution that we talked about involved removing this signal, and finding the correct ones like rowsInserted and rowsRemoved.



src/lib/GeoDataTreeModel.cpp
<http://git.reviewboard.kde.org/r/103167/#comment7326>

    layoutChanged as per documentation happens after a sort. The distinction in signals are subtle but i think we shouldn't use this one.


- Thibaut Gridel


On Nov. 17, 2011, 3:24 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103167/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 3:24 p.m.)
> 
> 
> Review request for Marble and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> GeometryLayer and PlacemarkLayout are currently wired up in MarbleMap. Since MarbleMap is basically a container for layers, it shouldn't have to know about implementation details of any specific layer. Therefore, the connect() statements should move into the respective layers themselves.
> 
> Before the connections can be wired up in the layers, a change to GeoDataTreeModel should be made: The treeChanged() signal seems redundant to QAbstractItemModel::layoutChanged(), and is currently only used for updating GeometryLayer and PlacemarkLayout. Therefore, GeoDataTreeModel can emit layoutChanged() such that treeChanged() can be removed.
> 
> 
> Diffs
> -----
> 
>   src/lib/GeoDataTreeModel.h fa919ba 
>   src/lib/GeoDataTreeModel.cpp 3056153 
>   src/lib/MarbleMap.cpp 3eb5a76 
>   src/lib/layers/GeometryLayer.cpp 53b5c32 
>   src/lib/layers/PlacemarkLayout.cpp 6cf3943 
> 
> Diff: http://git.reviewboard.kde.org/r/103167/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me. I'm not sure whether all changes of the models are correctly caught by the layers, esp. in the PlacemarkLayer. Please report any issues you see. Thx!
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111204/a3c33b36/attachment.html>