[Marble-devel] Review Request: Refactor route rendering colors: hardcoded --> config file

[Florian Eßer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103314/
-----------------------------------------------------------

(Updated Dec. 3, 2011, 2:29 p.m.)


Review request for Marble.


Changes
-------

Removed the UI changes, they have nothing to do with this patch...


Description (updated)
-------

Based on the discussion from https://git.reviewboard.kde.org/r/102540/ this patch turns the hardcoded colors in the routing layer into softcoded colors and alpha values that are stored in the config files.


Diffs (updated)
-----

  src/QtMainWindow.cpp 1c24071 
  src/lib/routing/RoutingLayer.cpp a5454ee 
  src/lib/routing/RoutingManager.h dad9357 
  src/lib/routing/RoutingManager.cpp 8488a56 
  src/marble.kcfg 5f5dfa2 
  src/marble_part.cpp 1bad437 

Diff: http://git.reviewboard.kde.org/r/103314/diff/diff


Testing (updated)
-------

Done for both KDE and Qt-only:
* compile
* start and close Marble --> default values are written to config file (Qt)
* manually edit the config files (~/.kde/share/config/marblerc and ~/.config/kde.org/Marble Desktop Globe.conf) and add/change the colors and alpha values there
* start Marble again --> route is rendered in different color

I could only test the default route color. I guess the other two are used while GPS navigating?


Thanks,

Florian Eßer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111203/48ba04ca/attachment.html>