[Marble-devel] Review Request: Refactor route rendering colors: hardcoded --> config file

[Florian Eßer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103314/
-----------------------------------------------------------

Review request for Marble.


Description
-------

Based on the discussion from https://git.reviewboard.kde.org/r/102540/ this patch turns the hardcoded colors in the routing layer into softcoded colors and alpha values that are stored in the config files.

Is this approach with invisible kcfg input widgets the right way to go? It feels somewhat strange...


Diffs
-----

  src/lib/routing/RoutingLayer.cpp a5454ee 
  src/QtMainWindow.cpp 1c24071 
  src/lib/routing/RoutingManager.h dad9357 
  src/lib/routing/RoutingManager.cpp 8488a56 
  src/lib/routing/RoutingProfilesWidget.cpp 88c880e 
  src/lib/routing/RoutingSettingsWidget.ui 27849c2 
  src/marble.kcfg 5f5dfa2 
  src/marble_part.cpp 1bad437 

Diff: http://git.reviewboard.kde.org/r/103314/diff/diff


Testing
-------

Done for both KDE and Qt-only:
* compile
* start and close Marble --> default values are written to config file
* manually edit the config files (~/.kde/share/config/marblerc and ~/.config/kde.org/Marble Desktop Globe.conf) and change the colors and alpha values there
* start Marble again --> route is rendered in different color

I could only test the default route color. I guess the other two are used while GPS navigating?


Thanks,

Florian Eßer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111203/96e5c0fe/attachment.html>