[Marble-devel] Review Request: Offline OpenStreetMap Address Search

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101245/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

This is the initial version of a search runner plugin that adds offline address search. I thought I'd rather push it now in an earlier stage to have the majority of the code in place before the upcoming freezes.

The patch contains the reading part: A runner plugin for Marble that works on one or more placemarks.dat files found somewhere in $MARBLE_DATADIR/maps/earth/monav/. I plan to extend the existing monav offline maps by such placemarks.dat files once the file format is reasonably stable. I'll commit the writing part (.osm parser and preprocessing) at a later point. It's only used to create placemarks.dat files, i.e. doesn't affect the Marble code.

Things I hope to get done for 1.2 for this plugin which are not in this patch are
- Searching the file on disk, not in memory
- Better search term parsing (e.g. handling house numbers)
- Improved parser (filter duplicates and unrelated placemarks, find more relevant placemarks, region hierarchies)


Diffs
-----

  src/plugins/runner/CMakeLists.txt e63407a 
  src/plugins/runner/local-osm-search/CMakeLists.txt PRE-CREATION 
  src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.h PRE-CREATION 
  src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp PRE-CREATION 
  src/plugins/runner/local-osm-search/LocalOsmSearchRunner.h PRE-CREATION 
  src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp PRE-CREATION 
  src/plugins/runner/local-osm-search/OsmDatabase.h PRE-CREATION 
  src/plugins/runner/local-osm-search/OsmDatabase.cpp PRE-CREATION 
  src/plugins/runner/local-osm-search/OsmPlacemark.h PRE-CREATION 
  src/plugins/runner/local-osm-search/OsmPlacemark.cpp PRE-CREATION 
  src/plugins/runner/local-osm-search/OsmRegion.h PRE-CREATION 
  src/plugins/runner/local-osm-search/OsmRegion.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101245/diff


Testing
-------

Mostly with http://nienhueser.de/marble/placemarks.dat. Place that file in ~/.local/share/marble/maps/earth/monav/hamburg/ and search for streets or places in Hamburg to see it running. Notice that the file format will change and that the file above contains multiple entries and lots of other quirks.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110427/9e4141c3/attachment.htm