[Marble-devel] Re: Review Request: Make it much easier to build and run marble from an IDE like QtCreator.

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6574/#review10065
-----------------------------------------------------------


It doesn't look like a good idea to merge build dir and install dir.
Moreover, cmake proposes -DCMAKE_INSTALL_PREFIX to install to a local/ and QtCreator proposes deployment step before running an app.

- Thibaut


On March 3, 2011, 11:06 p.m., Andrew Manson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6574/
> -----------------------------------------------------------
> 
> (Updated March 3, 2011, 11:06 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Make it much easier to build and run marble from an IDE like QtCreator. 
> 
> This change is really just a change to the cmake configuration files that copies the data into the cmake build directory while cmake is being run. Any code changes are just to facilitate looking relative to the executable for data files. 
> 
> This is a proof of concept patch and needs discussion. Once approved the rest of the Data marble/data/CMakeLists.txt file can be converted to using the new handy macro with very little effort. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1223576 
>   trunk/KDE/kdeedu/marble/src/lib/MapThemeManager.cpp 1223576 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.h 1223576 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.cpp 1223576 
> 
> Diff: http://svn.reviewboard.kde.org/r/6574/diff
> 
> 
> Testing
> -------
> 
> I have only tested this running the QT_ONLY version from within qtcreator. I have not tested running "make install" but I am confident that I have not changed any of the logic in the CMake Script so the install path should not have changed. 
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110417/9f4164be/attachment.htm