[Marble-devel] Review Request: "Directions to/from here" context menu entries

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5264/#review7535
-----------------------------------------------------------

Ship it!


Nice. Code looks good. I've tested it and the UI changes are good as well (I need to create some icons though ..). Ship it!
I think the direction stuff is lacking a bit feedback still to let the user know that Marble is evaluating the route .... Currently I click the points. Nothing seems to happen. Then the route is drawn and then there is a situation where I don't know whether I'll receive driving instructions eventually ....

- Torsten


On 2010-09-05 12:52:56, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5264/
> -----------------------------------------------------------
> 
> (Updated 2010-09-05 12:52:56)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Google Maps and other services made people used to "Directions from here" and "Directions to here" context menu entries. This patch adds them to Marble.
> 
> Note that this will make the Routing feature available to applications embedding a MarbleWidget, though in this scenario the two actions do not work yet (they'll do nothing). I expect to fix that in time for 4.6 though when working on https://bugs.kde.org/show_bug.cgi?id=248086
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.h 1171823 
>   /branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp 1171823 
> 
> Diff: http://svn.reviewboard.kde.org/r/5264/diff
> 
> 
> Testing
> -------
> 
> Various combinations of empty and existing routes.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100911/28e2120a/attachment-0001.htm