[Marble-devel] Review Request: "Directions to/from here" context menu entries

Dennis Nienhüser earthwings at gentoo.org
Sun Sep 5 14:52:56 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5264/
-----------------------------------------------------------

(Updated 2010-09-05 12:52:56.442954)


Review request for marble.


Changes
-------

Extends the previous patch to add a new "Address Details" action to the left mouse button popup next to the Copy Coordinates action. It does a reverse geocoding request and presents the result in a message box. Simple, but useful.

This update is independent of the previous patch feature-wise, but shares some code with it. Therefore I'm just appending it here.


Summary
-------

Google Maps and other services made people used to "Directions from here" and "Directions to here" context menu entries. This patch adds them to Marble.

Note that this will make the Routing feature available to applications embedding a MarbleWidget, though in this scenario the two actions do not work yet (they'll do nothing). I expect to fix that in time for 4.6 though when working on https://bugs.kde.org/show_bug.cgi?id=248086


Diffs (updated)
-----

  /branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.h 1171823 
  /branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp 1171823 

Diff: http://svn.reviewboard.kde.org/r/5264/diff


Testing
-------

Various combinations of empty and existing routes.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100905/4211a5da/attachment.htm 


More information about the Marble-devel mailing list