[Marble-devel] Review Request: Move duplicated print methods to ControlView

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5250/#review7394
-----------------------------------------------------------

Ship it!


Nice.
I wonder whether this stuff shouldn't actually go into MarbleWidget/MarbleMap instead. This would be similarly inspired to:

void QWebView::print ( QPrinter * printer ) const   [slot]
void QTextEdit::print ( QPrinter * printer ) const

- Torsten


On 2010-09-03 19:07:47, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5250/
> -----------------------------------------------------------
> 
> (Updated 2010-09-03 19:07:47)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> QtMainWindow and marble_part have four printing related methods with nearly identical code. The patch moves them to ControlView to avoid the redundancy.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/ControlView.h 1171147 
>   /trunk/KDE/kdeedu/marble/src/ControlView.cpp 1171147 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1171147 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1171147 
>   /trunk/KDE/kdeedu/marble/src/marble_part.h 1171147 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1171147 
> 
> Diff: http://svn.reviewboard.kde.org/r/5250/diff
> 
> 
> Testing
> -------
> 
> Qt and KDE version.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100903/e3c2a968/attachment-0001.htm