[Marble-devel] Review Request: Move duplicated print methods to ControlView

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5250/
-----------------------------------------------------------

Review request for marble.


Summary
-------

QtMainWindow and marble_part have four printing related methods with nearly identical code. The patch moves them to ControlView to avoid the redundancy.


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/ControlView.h 1171147 
  /trunk/KDE/kdeedu/marble/src/ControlView.cpp 1171147 
  /trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1171147 
  /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1171147 
  /trunk/KDE/kdeedu/marble/src/marble_part.h 1171147 
  /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1171147 

Diff: http://svn.reviewboard.kde.org/r/5250/diff


Testing
-------

Qt and KDE version.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100903/ce3fb9e7/attachment.htm