[Marble-devel] Re: Review Request: Dgml Time tag handler

[hjain.itbhu at gmail.com]

> On 2010-08-17 22:50:37, jmho wrote:
> > Could you please explain a little bit what this patch does and what changes are made in the respective classes?

This patch is adding a dgml time tag, which provides functionality to merge different monthly themes. Following is the explanation about changes in this patch :-
MarbleClock - dateChanged() and timeSet() signals are added.

MarbleModel - 
1. mapTexture() - This slot is invoked whenever date of clock is changed or time is set manually. This slot maps the texture on the current Projection, which help to change the theme from July to December.
2. texture()  - This return texture of textureLayer of current theme
3. datetimeMatch() - Returns whether the current clock time is subset of @param. datetimeMatch() uses parseRange() and fillRange().
4. textureLayer() - This return textureLayer of current theme. textureLayer() uses the datetimeMatch() to find the current theme out of various backend themes.

GeoSceneLayer - m_time is used to store information about time tag of layer. setTime() and time() are functions to set and get m_time.

GeoSceneMap - layers() return all the backend layers which of @param type (e.g. texture)

StackedTileLoader - Previously the name of the layer was choosen by the name of the theme, since the was only one texture layer per theme. But now there will be many texture layers per theme, the new code takes all the texture layers into the account. The logic of using only texture layer is previous code is finding the texture layer out of all the scenelayers. The code to insert new values to m_textureLayers and m_sceneLayers qhash has been brought inside the loop.

Kindly check the written in  StackedTileLoader class is correct logically or not. On running the code, I am getting the desired and corrent results.


> On 2010-08-17 22:50:37, jmho wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp, line 411
> > <http://svn.reviewboard.kde.org/r/4988/diff/3/?file=34091#file34091line411>
> >
> >     I guess this change was not intended.

Yes, adding the space was not intended.


- hjain


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4988/#review7122
-----------------------------------------------------------


On 2010-08-17 09:19:43, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4988/
> -----------------------------------------------------------
> 
> (Updated 2010-08-17 09:19:43)
> 
> 
> Review request for marble and Bastian Holst.
> 
> 
> Summary
> -------
> 
> This patch merges Temperature(July) and Temperature(Dec) themes into Temperature theme by using dgml time tag. Similar, for Precipitation themes.
> Kindly download the earth folder from http://uploading.com/files/5e9755bd/earth.tar.gz/ and replace it with marble/data/maps/earth folder.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1162190 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec-preview.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec.dgml 1162190 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/precip-jul/precip-jul.jpg UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip-preview.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip.dgml PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec-preview.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec.dgml 1162190 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/temp-jul/temp-jul.jpg UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp-preview.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp.dgml PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.h 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.cpp 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.h 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.cpp 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.h 1162190 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.cpp 1162190 
>   /trunk/KDE/kdeedu/marble/src/marble_part.rc 1162190 
> 
> Diff: http://svn.reviewboard.kde.org/r/4988/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101031/2a9cc776/attachment.htm