[Marble-devel] Re: Review Request: KML file loading via DBus

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5691/#review8450
-----------------------------------------------------------

Ship it!


Haven't tested the dbus interface.
API deprecation ok.
Maybe we want to also rename the misleading addPlacemark* into addGeoData* to be more accurate...


/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h
<http://svn.reviewboard.kde.org/r/5691/#comment8804>

    Hadn't noticed the old comment...
    GeoDataDocument please!



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h
<http://svn.reviewboard.kde.org/r/5691/#comment8805>

    ditto



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h
<http://svn.reviewboard.kde.org/r/5691/#comment8806>

    the string containing kml or gpx file content


- Thibaut


On 2010-10-25 19:29:18, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5691/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 19:29:18)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Makes addPlacemarkFile and associated methods slots to have them available via DBus. Adds a deprecation warning (doxygen only) to openGpxFile which internally does the same as addPlacemarkFile anyway. Removes some uneeded code (gpx vs other file types distinction) from QtMainWindow and marble_part.
> 
> 
> This addresses bug 253305.
>     https://bugs.kde.org/show_bug.cgi?id=253305
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1189732 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1189732 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1189732 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1189732 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1189732 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1189732 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1189732 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1189732 
> 
> Diff: http://svn.reviewboard.kde.org/r/5691/diff
> 
> 
> Testing
> -------
> 
> Gpx and kml files can still be loaded with the KDE and Qt version. DBus calls like qdbus org.kde.marble-12802 /MarbleMap addPlacemarkFile /tmp/tmp.rXGRuAT8aH/doc.kml can be used for the KDE application.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101030/51a79520/attachment.htm