[Marble-devel] Review Request: KML file loading via DBus

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5691/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Makes addPlacemarkFile and associated methods slots to have them available via DBus. Adds a deprecation warning (doxygen only) to openGpxFile which internally does the same as addPlacemarkFile anyway. Removes some uneeded code (gpx vs other file types distinction) from QtMainWindow and marble_part.


This addresses bug 253305.
    https://bugs.kde.org/show_bug.cgi?id=253305


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1189732 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1189732 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1189732 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1189732 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1189732 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1189732 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1189732 
  /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1189732 

Diff: http://svn.reviewboard.kde.org/r/5691/diff


Testing
-------

Gpx and kml files can still be loaded with the KDE and Qt version. DBus calls like qdbus org.kde.marble-12802 /MarbleMap addPlacemarkFile /tmp/tmp.rXGRuAT8aH/doc.kml can be used for the KDE application.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101025/d7de5f01/attachment.htm