[Marble-devel] Re: Review Request: Handle dirty-flag within MarbleMap

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5534/#review8040
-----------------------------------------------------------

Ship it!


Looks good :-) Only really important thing to be fixed is the introduction of the private slot. See below.


/trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h
<http://svn.reviewboard.kde.org/r/5534/#comment8264>

    Do not use private slots in public classes. 
    Use Q_PRIVATE_SLOT instead.



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp
<http://svn.reviewboard.kde.org/r/5534/#comment8266>

    please don't make use of the c++ keyword "new" for variables. 



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp
<http://svn.reviewboard.kde.org/r/5534/#comment8267>

    please don't make use of the C++ keyword "new" for variables.


- Torsten


On 2010-10-06 12:20:08, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5534/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 12:20:08)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Handling the dirty-flag within MarbleMap makes its use simpler (no need to remember to set the dirty-bit).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap_p.h 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/lib/NavigationWidget.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp 1183163 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1183163 
> 
> Diff: http://svn.reviewboard.kde.org/r/5534/diff
> 
> 
> Testing
> -------
> 
> Seems to work fine. Tested with the KDE version of Marble.
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101008/eb7d458b/attachment-0001.htm