[Marble-devel] Re: Review Request: Handle dirty-flag within MarbleMap

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5534/
-----------------------------------------------------------

(Updated 2010-10-06 12:20:08.362555)


Review request for marble.


Changes
-------

Also remove updateChangedMap(), which indirectly set the dirty-flag. This further reduces duplicate code.


Summary
-------

Handling the dirty-flag within MarbleMap makes its use simpler (no need to remember to set the dirty-bit).


Diffs (updated)
-----

  /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap_p.h 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/lib/NavigationWidget.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp 1183163 
  /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1183163 

Diff: http://svn.reviewboard.kde.org/r/5534/diff


Testing
-------

Seems to work fine. Tested with the KDE version of Marble.


Thanks,

Bernhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101006/f50055e5/attachment.htm