[Marble-devel] Re: Review Request: Implement font and angle unit config setting methods in MarbleWidget rather than in MarbleMap. Remove them from MarbleMap.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5533/#review8016
-----------------------------------------------------------


It would be helpful if you could create a document which would describe which classes should have which kind of functionality/methods and how they relate to each other. This could be done as part of the API docs. It would also be cool if you'd give a bit of an update about how the OpenGL stuff integrates with the MarbleWidget / MarbleMap design. :-)

- Torsten


On 2010-10-05 19:59:46, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5533/
> -----------------------------------------------------------
> 
> (Updated 2010-10-05 19:59:46)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> For the OpenGL mode, I need some other place than MarbleMap for these methods. I put them in MarbleWidget because AFAIK MarbleModel is not supposed to store user data.
> 
> Is it ok to commit?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1182855 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1182855 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1182855 
> 
> Diff: http://svn.reviewboard.kde.org/r/5533/diff
> 
> 
> Testing
> -------
> 
> Tested with the KDE version of Marble.
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101007/46f9705e/attachment.htm