[Marble-devel] Review Request: Implement font and angle unit config setting methods in MarbleWidget rather than in MarbleMap. Remove them from MarbleMap.

Bernhard Beschow bbeschow at cs.tu-berlin.de
Tue Oct 5 21:59:46 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5533/
-----------------------------------------------------------

Review request for marble.


Summary
-------

For the OpenGL mode, I need some other place than MarbleMap for these methods. I put them in MarbleWidget because AFAIK MarbleModel is not supposed to store user data.

Is it ok to commit?


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1182855 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1182855 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1182855 

Diff: http://svn.reviewboard.kde.org/r/5533/diff


Testing
-------

Tested with the KDE version of Marble.


Thanks,

Bernhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101005/0441a72e/attachment.htm 


More information about the Marble-devel mailing list