[Marble-devel] Re: Review Request: Earthquake Online Service

[Dennis Nienhüser]

> On 2010-11-28 21:40:16, Torsten Rahn wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp, line 86
> > <http://svn.reviewboard.kde.org/r/5995/diff/1/?file=41809#file41809line86>
> >
> >     What about having different colors for different magnitude ranges:
> >     We could have
> >     
> >     Minor/Micro earthquakes in green
> >     Light earthquakes in yellow
> >     Moderate earthquakes in orange
> >     Strong-Epic earthquakes in red
> >     (all colors in oxygen palette of course)
> >     See
> >     
> >     http://en.wikipedia.org/wiki/Richter_magnitude_scale
> >     
> >     for categories.
> >

Sounds good.


> On 2010-11-28 21:40:16, Torsten Rahn wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp, line 98
> > <http://svn.reviewboard.kde.org/r/5995/diff/1/?file=41809#file41809line98>
> >
> >     Have you checked  how much time it takes to draw this SVG? Sometimes drawing SVGs takes quite some time.

Shouldn't be an issue -- the svg is trivial (a simple polygon, no blurring or similar involved) and it is cached to a pixmap after the first painting, i.e. the svg renderer only renders it once (for every item).


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5995/#review9023
-----------------------------------------------------------


On 2010-11-28 17:25:24, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5995/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 17:25:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> The patch adds an online service that displays recent (up to one month ago) earthquake in the viewport.
> 
> Merely acting as a proxy for this review request: The patch is based on the excellent work of Utku Aydin in a Google Code-in task. I just added the seismograph background svg, changed the sort order to earthquake magnitude (i.e. the twenty earthquakes with highest magnitude are shown on the screen) and adjusted the code style to Marble's.
> 
> I'll delay the commit until 4.6 is branched off.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1201749 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/earthquake.qrc PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/seismograph.svg PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5995/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Earthquake Plugin
>   http://svn.reviewboard.kde.org/r/5995/s/565/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101130/2d7b3ea1/attachment.htm