[Marble-devel] Re: Review Request: Earthquake Online Service

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5995/#review9025
-----------------------------------------------------------

Ship it!


Ship It! I wonder whether this patch couldn't still go into KDE 4.6 after kindly asking the translators for permission. It's a really neat feature imho with few added strings. Or we could introduce it for KDE 4.6.1 or 4.6.2 ...


- Torsten


On 2010-11-28 17:25:24, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5995/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 17:25:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> The patch adds an online service that displays recent (up to one month ago) earthquake in the viewport.
> 
> Merely acting as a proxy for this review request: The patch is based on the excellent work of Utku Aydin in a Google Code-in task. I just added the seismograph background svg, changed the sort order to earthquake magnitude (i.e. the twenty earthquakes with highest magnitude are shown on the screen) and adjusted the code style to Marble's.
> 
> I'll delay the commit until 4.6 is branched off.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1201749 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/earthquake.qrc PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/seismograph.svg PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5995/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Earthquake Plugin
>   http://svn.reviewboard.kde.org/r/5995/s/565/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101128/fed0375a/attachment.htm