[Marble-devel] Re: Review Request: Marble Desktop Globe => Marble Virtual Globe

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5839/#review8719
-----------------------------------------------------------


Is there a reason not to change the name in the license header? I don't see it ....

- Torsten


On 2010-11-13 11:27:19, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5839/
> -----------------------------------------------------------
> 
> Review request for marble and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> This renames (in the user visible parts) 'Marble Desktop Globe' to 'Marble Virtual Globe'.
> 
> I kept 'Marble Desktop Globe' as the name for the QSettings file as well as the group of the designer plugins to keep consistency there.
> 
> A place where we _could_ rename everything is the license header. Not sure about it, please comment. I'm talking about the 'This file is part of the Marble Desktop Globe.' line.
> 
> I think it should be committed soon given that string freeze has already passed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/ControlView.cpp 1196280 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1196280 
>   /trunk/KDE/kdeedu/marble/src/kdemain.cpp 1196280 
>   /trunk/KDE/kdeedu/marble/src/lib/GoToDialog.h 1196280 
>   /trunk/KDE/kdeedu/marble/src/lib/GoToDialog.cpp 1196280 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.ui 1196280 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.cpp 1196280 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1196280 
> 
> Diff: http://svn.reviewboard.kde.org/r/5839/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101114/923b51aa/attachment.htm