<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5839/">http://svn.reviewboard.kde.org/r/5839/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there a reason not to change the name in the license header? I don't see it ....</pre>
<br />
<p>- Torsten</p>
<br />
<p>On November 13th, 2010, 11:27 a.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Torsten Rahn.</div>
<div>By Dennis Nienhüser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This renames (in the user visible parts) 'Marble Desktop Globe' to 'Marble Virtual Globe'.
I kept 'Marble Desktop Globe' as the name for the QSettings file as well as the group of the designer plugins to keep consistency there.
A place where we _could_ rename everything is the license header. Not sure about it, please comment. I'm talking about the 'This file is part of the Marble Desktop Globe.' line.
I think it should be committed soon given that string freeze has already passed.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/ControlView.cpp <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/kdemain.cpp <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GoToDialog.h <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GoToDialog.cpp <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.ui <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.cpp <span style="color: grey">(1196280)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1196280)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>