[Marble-devel] Review requests: Marble Desktop Globe => Marble Virtual Globe and Separate version strings for Marble Virtual Globe and Marble Library
Dennis Nienhüser
earthwings at gentoo.org
Sat Nov 13 20:15:00 CET 2010
Hi,
looks like reviewboard is not in the mood of sending out mails today.
I'll do it instead:
#########
Separate version strings for Marble Virtual Globe and Marble Library
http://reviewboard.kde.org/r/5840/
Splits up the version string for the library and the applications (KDE
and Qt). The patch can be applied to branches/4.6 once it exists. The
version number for the applications is 0.80 (1.0 Beta 1), along the
lines of KDE versions (4.6 Beta 1 will be 4.5.80). Another option would
be 0.9.80.
* The KDE version about dialog reports 'Marble Virtual Globe' and the
application version.
* The Qt version about dialog reports 'Marble Virtual Globe' and the
application version.
* Embedded in another application, the about dialog reports 'Marble
Virtual Globe' without an application version. This can be overwritten
using MarbleAboutDialog::setApplicationTitle()
* MarbleAboutDialog (Qt version and when using MarbleWidget embedded)
also reports the Marble library version.
Note that the screenshots still have some 'Marble Desktop Globe' strings
that would change to 'Marble Virtual Globe' when applying the other patch.
##########
Marble Desktop Globe => Marble Virtual Globe
http://reviewboard.kde.org/r/5839/
This renames (in the user visible parts) 'Marble Desktop Globe' to
'Marble Virtual Globe'.
I kept 'Marble Desktop Globe' as the name for the QSettings file as well
as the group of the designer plugins to keep consistency there.
A place where we _could_ rename everything is the license header. Not
sure about it, please comment. I'm talking about the 'This file is part
of the Marble Desktop Globe.' line.
I think it should be committed soon given that string freeze has already
passed.
##########
Thanks,
Dennis
More information about the Marble-devel
mailing list