[Marble-devel] [Marble-commits] KDE/kdeedu/marble/src/plugins/render/aprs

[Jens-Michael Hoffmann]

Am Mittwoch, 19. Mai 2010, 21:05:19 schrieb Patrick von Reth:
> SVN commit 1128605 by vonreth:
> 
> no exports in a plugin
> 
>  M  +1 -1      qextserialport.h  
> 
> 
> --- trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport.h #1128604:1128605
> @@ -185,7 +185,7 @@
>  
>  \author Stefan Sander, Michal Policht, Brandon Fosdick, Liam Staskawicz
>  */
> -class QEXTSERIALPORT_EXPORT QextSerialPort: public QIODevice
> +class QextSerialPort: public QIODevice
>  {
>      Q_OBJECT
>      public:

Thanks for the contribution.

Imho this should be done differently, perhaps by defining QEXTSERIALPORT_EXPORT
with an appropriate value outside this source file.

Rationale: This is part of an embedded copy of the lib, so this change might get lost
if we update.


Kind regards,
Jens-Michael