[Marble-devel] Review Request: Simplified, faster background for overview map

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2716/#review5499
-----------------------------------------------------------


Hm, I tried to implement this for all backgrounds, but as marble renders all cached items with highest quality, this wouldn't affect all items and this looks strange.

This would create quite some work to implement it that it looks consistent and is faster than now.

- Bastian


On 2010-01-24 09:25:12, Ariya Hidayat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2716/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 09:25:12)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> In low-quality mode, the overview map will have a simplified but faster background. First of all, border is skipped. Also, only opaque solid color is considered, which will skip the expensive alpha-blending (SourceOver composition) altogether. In addition, fillRect is way faster than drawPath.
> 
> Question: shall we generalize this to FrameGraphicsItem/AbstractFloatItem so that all the layers can contribute to the animation rendering speed-up?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h 1079360 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1079360 
> 
> Diff: http://reviewboard.kde.org/r/2716/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ariya
> 
>