[Marble-devel] Review Request: Removing QPixmap from GeoData-classes

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3855/
-----------------------------------------------------------

(Updated 2010-05-07 14:47:30.163824)


Review request for marble.


Changes
-------

GeoDataColorStyle and GeoDataIconStyle are implicitly shared now.


Summary (updated)
-------

Removing QPixmap from GeoData-classes, as it is not save to be used in a thread other than the ui-thread. GeoData* are created in such a thread.
Making GeoDataColorStyle and GeoDataIconStyle implicitly shared.


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/lib/VisiblePlacemark.cpp 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.h 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.cpp 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.h 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.cpp 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.h 1123930 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.cpp 1123930 

Diff: http://reviewboard.kde.org/r/3855/diff


Testing (updated)
-------

Crashes on exit in ~GeoDataRegionPrivate


Thanks,

Bastian