[Marble-devel] Review Request: Add the APRS plugin back into the online view menu

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4428/#review6246
-----------------------------------------------------------

Ship it!


Except the following micro-issue the patch looks good!


trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp
<http://reviewboard.kde.org/r/4428/#comment5841>

    Here you could need some spaces.


- Bastian


On 2010-06-21 18:07:01, Wes Hardaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4428/
> -----------------------------------------------------------
> 
> (Updated 2010-06-21 18:07:01)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This is a follow on to the other review (4410) to allow the APRS plugin to make use of the new non-class-tree-specific online menu entry system.  With this patch and the other one, the APRS plugin now appears is the View/Online Services menu again.  This patch also prevents the network gathereres from collecting data when it's not visible.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.h 1140837 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp 1140837 
> 
> Diff: http://reviewboard.kde.org/r/4428/diff
> 
> 
> Testing
> -------
> 
> Built, compiled and tested to ensure network activity stops when the checkbox is off in the view menu.
> 
> 
> Thanks,
> 
> Wes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100622/b539296f/attachment.htm