[Marble-devel] Review Request: GeoData: showcase test for pointer-based GeoData

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4285/
-----------------------------------------------------------

Review request for marble.


Summary
-------

providing a (naive) pointer-based api for GeoDataContainer, and test case which shows early breaks...

Toggle between the two "document.append(folder);" shows how brittle the api still is.


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1136081 
  /trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1136081 

Diff: http://reviewboard.kde.org/r/4285/diff


Testing
-------

Run TestGeoData :(


Thanks,

Thibaut