[Marble-devel] Review Request: Bookmark Feature Progress

[1989.gaurav at gmail.com]

> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h, line 32
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28296#file28296line32>
> >
> >     this ctor does not accept one argument, so 'explicit' is not needed here

removed explicit


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h, line 38
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28296#file28296line38>
> >
> >     ref to const?

changed to    void addBookmark( const GeoDataPlacemark &bookmark ) const;


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h, line 42
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28296#file28296line42>
> >
> >     ref to const?

changed


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager_p.h, line 15
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28298#file28298line15>
> >
> >     no need to include, forward decl should be sufficient

done


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager_p.h, line 26
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28298#file28298line26>
> >
> >     no need to initialize with empty string, the default QString ctor is sufficient

removed


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp, line 99
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28301#file28301line99>
> >
> >     please use existing coding style, that is one line per item

Sorry, will keep in mode. modified


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h, line 55
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28302#file28302line55>
> >
> >     please keep alphabetic order

modified


> On 2010-06-09 19:03:09, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp, line 15
> > <http://reviewboard.kde.org/r/4269/diff/2/?file=28292#file28292line15>
> >
> >     please try to keep include order consistent (MarbleDebug is probably there because of search and replace with QDebug)

will keep in mind for future


- 1989gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4269/#review6062
-----------------------------------------------------------


On 2010-06-09 18:31:25, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4269/
> -----------------------------------------------------------
> 
> (Updated 2010-06-09 18:31:25)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> I have implemented most of the bookmarking and viewing. But It isn't working as expected. On startup it loads bookmark file MARBLE_DATA_PATH/bookmarks/bookmarks.kml and store it in a GeoDataDocument. On adding new bookmark, new node is appended in GeoDataDocument and bookmarks file is updated. On view GeoDataLookAt object is extracted and bookmark is shown using flyTo(GeoDataLookAt& ) method. 
> 
> File is getting modified properly, but flyTo is not working. run marble with --debug-info to print bookmark values added or read. Suggest me what could be the possible modifications.
> 
> It works only for Qt-Only version.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/data/bookmarks/bookmarks.kml PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager_p.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLookAt.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLookAt.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1136009 
> 
> Diff: http://reviewboard.kde.org/r/4269/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> bookmark feature
>   http://reviewboard.kde.org/r/4269/s/429/
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>