[Marble-devel] Review Request: Bookmark feature

[1989.gaurav at gmail.com]

> On 2010-06-04 19:24:34, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp, line 15
> > <http://reviewboard.kde.org/r/4225/diff/1/?file=27902#file27902line15>
> >
> >     not necessary to specify the lib directory

modified


> On 2010-06-04 19:24:34, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp, line 683
> > <http://reviewboard.kde.org/r/4225/diff/1/?file=27902#file27902line683>
> >
> >     probably not necessary, but I'm not sure

removed


> On 2010-06-04 19:24:34, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 22
> > <http://reviewboard.kde.org/r/4225/diff/1/?file=27904#file27904line22>
> >
> >     you could use the constructor initializer list to initialize m_widget

done


> On 2010-06-04 19:24:34, jmho wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt, line 17
> > <http://reviewboard.kde.org/r/4225/diff/1/?file=27907#file27907line17>
> >
> >     this change was probably not intended?

will not commit it to trunk, I enabled it for me only.


- 1989gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4225/#review5984
-----------------------------------------------------------


On 2010-06-04 16:40:25, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4225/
> -----------------------------------------------------------
> 
> (Updated 2010-06-04 16:40:25)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> A Step towards Bookmark feature implementation.
> Added addBookmark button which shows longitude, latitude and zoom level on console.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.h 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1133781 
> 
> Diff: http://reviewboard.kde.org/r/4225/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>