[Marble-devel] Review Request: Bookmark feature

[jensmh at gmx.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4225/#review5984
-----------------------------------------------------------


just some points from skimming over it


svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp
<http://reviewboard.kde.org/r/4225/#comment5600>

    not necessary to specify the lib directory



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp
<http://reviewboard.kde.org/r/4225/#comment5599>

    probably not necessary, but I'm not sure



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp
<http://reviewboard.kde.org/r/4225/#comment5597>

    you could use the constructor initializer list to initialize m_widget



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt
<http://reviewboard.kde.org/r/4225/#comment5598>

    this change was probably not intended?


- jmho


On 2010-06-04 16:40:25, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4225/
> -----------------------------------------------------------
> 
> (Updated 2010-06-04 16:40:25)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> A Step towards Bookmark feature implementation.
> Added addBookmark button which shows longitude, latitude and zoom level on console.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.h 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1133781 
> 
> Diff: http://reviewboard.kde.org/r/4225/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>