[Marble-devel] Review Request: remove GpsLayer [7 patches squashed]

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4210/#review5969
-----------------------------------------------------------

Ship it!


Looks good to me. Is this supposed to get backported?


/trunk/KDE/kdeedu/marble/src/MarbleTest.cpp
<http://reviewboard.kde.org/r/4210/#comment5593>

    Well, this qDebug message is superfuous now :)


- Torsten


On 2010-06-02 22:56:54, Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4210/
> -----------------------------------------------------------
> 
> (Updated 2010-06-02 22:56:54)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> patch 1 moves PositionTracking out of GpsLayer
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/MarbleTest.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayer.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayer.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackSegment.cpp 1133912 
> 
> Diff: http://reviewboard.kde.org/r/4210/diff
> 
> 
> Testing
> -------
> 
> compiles and keeps gps handling:
> - display arrow and track when gpsd selected
> - hides when no source selected
> 
> 
> Thanks,
> 
> Thibaut
> 
>