[Marble-devel] Review Request: remove GpsLayer [7 patches squashed]

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4210/#review5967
-----------------------------------------------------------


Great patch, it eliminates a couple of wtfs in one go.


/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp
<http://reviewboard.kde.org/r/4210/#comment5589>

    +spaces



/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp
<http://reviewboard.kde.org/r/4210/#comment5590>

    +spaces



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp
<http://reviewboard.kde.org/r/4210/#comment5591>

    This (or another) repaint is now missing, which is good for performance, but leads to the track not being updated correctly as it moves. The current position indicator is repainted in PositionTracking, but the track itself not.



/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp
<http://reviewboard.kde.org/r/4210/#comment5592>

    +spaces


- Dennis


On 2010-06-02 22:56:54, Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4210/
> -----------------------------------------------------------
> 
> (Updated 2010-06-02 22:56:54)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> patch 1 moves PositionTracking out of GpsLayer
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/MarbleTest.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayer.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayer.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1133912 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackSegment.cpp 1133912 
> 
> Diff: http://reviewboard.kde.org/r/4210/diff
> 
> 
> Testing
> -------
> 
> compiles and keeps gps handling:
> - display arrow and track when gpsd selected
> - hides when no source selected
> 
> 
> Thanks,
> 
> Thibaut
> 
>