[Marble-devel] Review Request: Move tileSize() from AbstractScanlineTextureMapper to GeoSceneTexture

[Bernhard Beschow]

> On 2010-07-09 15:08:39, jmho wrote:
> > trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h, line 138
> > <http://reviewboard.kde.org/r/4561/diff/1/?file=30599#file30599line138>
> >
> >     This might still have its merits. m_tileSize is used in some performance critical sections.

I kept it in the commit. The tile size is now cached.


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4561/#review6447
-----------------------------------------------------------


On 2010-07-09 14:43:20, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4561/
> -----------------------------------------------------------
> 
> (Updated 2010-07-09 14:43:20)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This will make WMS support much cleaner.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.cpp 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1147994 
>   trunk/KDE/kdeedu/marble/src/tilecreator/CMakeLists.txt 1147994 
> 
> Diff: http://reviewboard.kde.org/r/4561/diff
> 
> 
> Testing
> -------
> 
> Works for me. Please test!
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100710/84daa423/attachment.htm