[Marble-devel] Review Request: Move tileSize() from AbstractScanlineTextureMapper to GeoSceneTexture

[jensmh at gmx.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4561/#review6447
-----------------------------------------------------------

Ship it!


The patch looks good to me. It is definitely an improvement over the current state.
Before committing, could you please check if there are performance regressions?


trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h
<http://reviewboard.kde.org/r/4561/#comment6175>

    This might still have its merits. m_tileSize is used in some performance critical sections.


- jmho


On 2010-07-09 14:43:20, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4561/
> -----------------------------------------------------------
> 
> (Updated 2010-07-09 14:43:20)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This will make WMS support much cleaner.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.cpp 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1147994 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1147994 
>   trunk/KDE/kdeedu/marble/src/tilecreator/CMakeLists.txt 1147994 
> 
> Diff: http://reviewboard.kde.org/r/4561/diff
> 
> 
> Testing
> -------
> 
> Works for me. Please test!
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100709/eb7de6c9/attachment.htm