[Marble-devel] Review Request: GeoData: showcase test for pointer-based GeoData
Bastian Holst
bastianholst at gmx.de
Fri Jul 9 11:36:06 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4285/#review6437
-----------------------------------------------------------
Your patch introduced a lot of compiler warning:
[ 21%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataFolder.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFolder.cpp:27:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 21%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataObject.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataAbstractView.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataCoordinates.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLineString.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataContainer.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer.cpp:15:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLinearRing.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataColorStyle.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataRegion.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.cpp:13:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataPolyStyle.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataStyleMap.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataStyle.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataIconStyle.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLookAt.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataDocument.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataDocument_p.h:16,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataDocument.cpp:24:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLatLonBox.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataHotSpot.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataExtendedData.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLod.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLatLonAltBox.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLabelStyle.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataGeometry.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataPlacemark.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataPlacemark_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataPlacemark.cpp:18:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataFeature.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature.cpp:14:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 26%] Building
[ 37%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlLatLonAltBoxTagHandler.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/handlers/kml/KmlLatLonAltBoxTagHandler.cpp:18:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 37%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlColorModeTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlFolderTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlDescriptionTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlHrefTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlExtendedDataTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlCountrycodeTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlWidthTagHandler.o
[ 39%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/Kml_scaleTagHandler.o
[ 39%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlLodTagHandler.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/handlers/kml/KmlLodTagHandler.cpp:18:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
- Bastian
On 2010-07-08 18:08:35, Thibaut Gridel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4285/
> -----------------------------------------------------------
>
> (Updated 2010-07-08 18:08:35)
>
>
> Review request for marble.
>
>
> Summary
> -------
>
> providing a (naive) pointer-based api for GeoDataContainer, and test case which shows early breaks...
>
> Toggle between the two "document.append(folder);" shows how brittle the api still is.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1147288
> /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/FileManager.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.h PRE-CREATION
> /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp PRE-CREATION
> /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry_p.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1147288
> /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp 1147288
> /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h 1147288
> /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp 1147288
> /trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1147288
>
> Diff: http://reviewboard.kde.org/r/4285/diff
>
>
> Testing
> -------
>
> Run TestGeoData :(
>
>
> Thanks,
>
> Thibaut
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100709/b5d34980/attachment-0001.htm
More information about the Marble-devel
mailing list