[Marble-devel] Review Request: GeoData: showcase test for pointer-based GeoData

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4285/
-----------------------------------------------------------

(Updated 2010-07-08 18:08:35.220687)


Review request for marble.


Changes
-------

updated patch with points taken in.
I also removed the nodeType in Georender plugin, which should both be more respectful or RTTI and plugin compile symbols.


Summary
-------

providing a (naive) pointer-based api for GeoDataContainer, and test case which shows early breaks...

Toggle between the two "document.append(folder);" shows how brittle the api still is.


Diffs (updated)
-----

  /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/FileManager.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry_p.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1147288 
  /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp 1147288 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h 1147288 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp 1147288 
  /trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1147288 

Diff: http://reviewboard.kde.org/r/4285/diff


Testing
-------

Run TestGeoData :(


Thanks,

Thibaut

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100708/8f429031/attachment.htm