[Marble-devel] Review Request: This fixes the bug on solaris where another header is needed for the serial port support

[Wes Hardaker]

> On 2010-07-06 14:47:11, Bastian Holst wrote:
> > Hard to find out, if it works now. Could you try to contact a KDE Solaris guy?

Well, I don't know any though I'm sure I could go look.  However, if you look at the diff it also shouldn't hurt anything and certainly should be helping.


- Wes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4509/#review6386
-----------------------------------------------------------


On 2010-07-02 13:40:15, Wes Hardaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4509/
> -----------------------------------------------------------
> 
> (Updated 2010-07-02 13:40:15)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This adds a CMake test for the sys/filio.h header file which is needed on solaris (and doesn't exist on linux).  It then includes that file on solaris if found.
> 
> 
> This addresses bug 242039.
>     https://bugs.kde.org/show_bug.cgi?id=242039
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/CMakeLists.txt 1144658 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/aprsconfig.h.in PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/posix_qextserialport.cpp 1144658 
> 
> Diff: http://reviewboard.kde.org/r/4509/diff
> 
> 
> Testing
> -------
> 
> built and tested on linux; not on solaris
> 
> 
> Thanks,
> 
> Wes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100707/8c1e58b0/attachment.htm