<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4509/">http://reviewboard.kde.org/r/4509/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 6th, 2010, 2:47 p.m., <b>Bastian Holst</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Hard to find out, if it works now. Could you try to contact a KDE Solaris guy?</pre>
</blockquote>
</blockquote>
<pre>Well, I don't know any though I'm sure I could go look. However, if you look at the diff it also shouldn't hurt anything and certainly should be helping.</pre>
<br />
<p>- Wes</p>
<br />
<p>On July 2nd, 2010, 1:40 p.m., Wes Hardaker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Wes Hardaker.</div>
<p style="color: grey;"><i>Updated 2010-07-02 13:40:15</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This adds a CMake test for the sys/filio.h header file which is needed on solaris (and doesn't exist on linux). It then includes that file on solaris if found.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">built and tested on linux; not on solaris</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=242039">242039</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeedu/marble/src/plugins/render/aprs/CMakeLists.txt <span style="color: grey">(1144658)</span></li>
<li>trunk/KDE/kdeedu/marble/src/plugins/render/aprs/aprsconfig.h.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdeedu/marble/src/plugins/render/aprs/posix_qextserialport.cpp <span style="color: grey">(1144658)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4509/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>