[Marble-devel] Review Request: This fixes the bug on solaris where another header is needed for the serial port support

Wes Hardaker wjhns25 at hardakers.net
Fri Jul 2 15:40:16 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4509/
-----------------------------------------------------------

Review request for marble.


Summary
-------

This adds a CMake test for the sys/filio.h header file which is needed on solaris (and doesn't exist on linux).  It then includes that file on solaris if found.


This addresses bug 242039.
    https://bugs.kde.org/show_bug.cgi?id=242039


Diffs
-----

  trunk/KDE/kdeedu/marble/src/plugins/render/aprs/CMakeLists.txt 1144658 
  trunk/KDE/kdeedu/marble/src/plugins/render/aprs/aprsconfig.h.in PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/plugins/render/aprs/posix_qextserialport.cpp 1144658 

Diff: http://reviewboard.kde.org/r/4509/diff


Testing
-------

built and tested on linux; not on solaris


Thanks,

Wes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100702/697d59d6/attachment-0001.htm 


More information about the Marble-devel mailing list