[Marble-devel] Review Request: Simplified, faster background for overview map

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2716/#review3832
-----------------------------------------------------------


> Question: shall we generalize this to FrameGraphicsItem/AbstractFloatItem
> so that all the layers can contribute to the animation rendering speed-up?

Yes, that sounds like a good idea.


- Torsten


On 2010-01-24 09:25:12, Ariya Hidayat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2716/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 09:25:12)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> In low-quality mode, the overview map will have a simplified but faster background. First of all, border is skipped. Also, only opaque solid color is considered, which will skip the expensive alpha-blending (SourceOver composition) altogether. In addition, fillRect is way faster than drawPath.
> 
> Question: shall we generalize this to FrameGraphicsItem/AbstractFloatItem so that all the layers can contribute to the animation rendering speed-up?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h 1079360 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1079360 
> 
> Diff: http://reviewboard.kde.org/r/2716/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ariya
> 
>