[Marble-devel] Re: Review Request: Map Creation Wizard GeoScene Refactoring

Utku Aydin utkuaydin34 at gmail.com
Fri Dec 31 19:42:27 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6228/
-----------------------------------------------------------

(Updated 2010-12-31 18:42:26.831140)


Review request for marble.


Changes
-------

Added GeoScene's string identifiers.


Summary
-------

Currently the Map Creation Wizard is making use of QXmlStreamWriter and feeds bare hardcoded strings into the DGML file. That's the first step of refactoring the Map Creation Wizard in a way so that it works based on GeoScene classes which has benefits in terms of extensibility, maintenance, etc.


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/lib/MapWizard.h 1209913 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp 1209913 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/6228/diff


Testing
-------


Thanks,

Utku

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101231/8b75d701/attachment.htm 


More information about the Marble-devel mailing list