[Marble-devel] Re: Review Request: Map Creation Wizard GeoScene Refactoring

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6228/#review9477
-----------------------------------------------------------

Ship it!


Nicely done! I've only a few comments.


trunk/KDE/kdeedu/marble/src/lib/MapWizard.h
<http://svn.reviewboard.kde.org/r/6228/#comment10490>

    Perhaps pass a "const GeoSceneDocument *" here?



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10488>

    You can probably pass a "const GeoSceneDocument *" here.



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10489>

    Perhaps "extension" can go if you would always use .png for preview icons?



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10487>

    Isn't that redundant to setSourceDir() below?


- Bernhard


On 2010-12-31 05:31:09, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6228/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 05:31:09)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Currently the Map Creation Wizard is making use of QXmlStreamWriter and feeds bare hardcoded strings into the DGML file. That's the first step of refactoring the Map Creation Wizard in a way so that it works based on GeoScene classes which has benefits in terms of extensibility, maintenance, etc.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h 1209913 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp 1209913 
> 
> Diff: http://svn.reviewboard.kde.org/r/6228/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101231/8b5c0fe5/attachment.htm