[Marble-devel] Re: Review Request: Create some standard context menu for all info boxes / float items in Marble

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6237/#review9475
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.h
<http://svn.reviewboard.kde.org/r/6237/#comment10484>

    Where's the implementation of this one?



/trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.cpp
<http://svn.reviewboard.kde.org/r/6237/#comment10483>

    Shouldn't that implementation rather go into the base class (e.g. MarbleGraphicsItem) ?


- Torsten


On 2010-12-30 10:49:44, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6237/
> -----------------------------------------------------------
> 
> (Updated 2010-12-30 10:49:44)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Creates a standard context menu for all float items with the actions "Hide", "Lock" and "Configure..." (if available).
> GCI task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129353653687
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.h 1210189 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.cpp 1210189 
> 
> Diff: http://svn.reviewboard.kde.org/r/6237/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101230/0e2b16c3/attachment.htm