[Marble-devel] Re: Review Request: Create some standard context menu for all info boxes / float items in Marble
Daniel Marth
danielmarth at gmx.at
Thu Dec 30 15:12:50 CET 2010
> On 2010-12-30 13:59:38, Torsten Rahn wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.h, line 75
> > <http://svn.reviewboard.kde.org/r/6237/diff/1/?file=43284#file43284line75>
> >
> > Where's the implementation of this one?
This method already existed, I just changed it from a public method to a public slot, that's why it is shown in the diff of the header, but not the source file.
> On 2010-12-30 13:59:38, Torsten Rahn wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.cpp, line 216
> > <http://svn.reviewboard.kde.org/r/6237/diff/1/?file=43285#file43285line216>
> >
> > Shouldn't that implementation rather go into the base class (e.g. MarbleGraphicsItem) ?
show()/hide() just call setVisible( bool ), which is also implemented in AbstractFloatItem.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6237/#review9475
-----------------------------------------------------------
On 2010-12-30 10:49:44, Daniel Marth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6237/
> -----------------------------------------------------------
>
> (Updated 2010-12-30 10:49:44)
>
>
> Review request for marble.
>
>
> Summary
> -------
>
> Creates a standard context menu for all float items with the actions "Hide", "Lock" and "Configure..." (if available).
> GCI task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129353653687
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.h 1210189
> /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.cpp 1210189
>
> Diff: http://svn.reviewboard.kde.org/r/6237/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101230/ec693251/attachment.htm
More information about the Marble-devel
mailing list