[Marble-devel] Re: Review Request: Map Creation Wizard GeoScene Refactoring

Utku Aydin utkuaydin34 at gmail.com
Tue Dec 28 17:31:40 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6228/
-----------------------------------------------------------

(Updated 2010-12-28 16:31:39.989635)


Review request for marble.


Changes
-------

* Add GeoSceneIcon and GeoSceneZoom
* Get rid of the d->map* attributes wherever possible.


Summary
-------

Currently the Map Creation Wizard is making use of QXmlStreamWriter and feeds bare hardcoded strings into the DGML file. That's the first step of refactoring the Map Creation Wizard in a way so that it works based on GeoScene classes which has benefits in terms of extensibility, maintenance, etc.


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/lib/MapWizard.h 1209913 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp 1209913 

Diff: http://svn.reviewboard.kde.org/r/6228/diff


Testing
-------

At the moment, GeoSceneDocument provides texts of summary page's labels.


Thanks,

Utku

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101228/73867d54/attachment-0001.htm 


More information about the Marble-devel mailing list