[Marble-devel] Re: Review Request: Map Creation Wizard GeoScene Refactoring

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6228/#review9447
-----------------------------------------------------------



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10445>

    use the data in GeoSceneDocument here instead of d->map*



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10446>

    use d->document here as well



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10447>

    use d->document here as well



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10448>

    I'd fill d->document here and get rid of handleDocumentAttributes()


- Bernhard


On 2010-12-28 10:55:06, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6228/
> -----------------------------------------------------------
> 
> (Updated 2010-12-28 10:55:06)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Currently the Map Creation Wizard is making use of QXmlStreamWriter and feeds bare hardcoded strings into the DGML file. That's the first step of refactoring the Map Creation Wizard in a way so that it works based on GeoScene classes which has benefits in terms of extensibility, maintenance, etc.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h 1209427 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp 1209427 
> 
> Diff: http://svn.reviewboard.kde.org/r/6228/diff
> 
> 
> Testing
> -------
> 
> At the moment, GeoSceneDocument provides texts of summary page's labels.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101228/8bb35549/attachment.htm