[Marble-devel] Review Request: turn GpFifo into a class

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6205/
-----------------------------------------------------------

Review request for marble.


Summary
-------

This patch resolves a small bug in the bumpmapping code where the gradient for the relief wasn't calculated properly.

It also turns the hidden union "GpFifo" in TextureColorizer.cpp into a proper FIFO class in order to make the code less fragile. The patch relies on very basic compiler optimizations, relinguishing usage of a union.

I get ~3.5 fps on my machine before and after this patch is applied.


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/TextureColorizer.cpp 1209213 

Diff: http://svn.reviewboard.kde.org/r/6205/diff


Testing
-------


Thanks,

Bernhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101225/2670bba2/attachment.htm