[Marble-devel] Re: Review Request: Map Creation Wizard

[Utku Aydin]

> On 2010-12-14 13:31:53, Bernhard Beschow wrote:
> > trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp, line 91
> > <http://svn.reviewboard.kde.org/r/6070/diff/3/?file=42519#file42519line91>
> >
> >     This connecton should go into the constructor. Otherwise parseServerCapabilities() will be called n times, where n is the number of times the "Inspect" button was pressed.

Should be fixed in Diff r4


> On 2010-12-14 13:31:53, Bernhard Beschow wrote:
> > trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp, line 112
> > <http://svn.reviewboard.kde.org/r/6070/diff/3/?file=42519#file42519line112>
> >
> >     "firstLayer" should have a better name. Perhaps "wmsReply"?

I think name is not that bad. Since all label elements stored in an element called "label", I can't find any other suitable name. :)


> On 2010-12-14 13:31:53, Bernhard Beschow wrote:
> > trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp, line 119
> > <http://svn.reviewboard.kde.org/r/6070/diff/3/?file=42519#file42519line119>
> >
> >     This connect statement should go into the constructor, too.

Should be fixed in Diff r4


- Utku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6070/#review9249
-----------------------------------------------------------


On 2010-12-14 21:27:33, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6070/
> -----------------------------------------------------------
> 
> (Updated 2010-12-14 21:27:33)
> 
> 
> Review request for marble, Torsten Rahn and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> Map wizard helps users create a new map easily.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1206280 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1206280 
>   trunk/KDE/kdeedu/marble/src/marble.kcfg 1206280 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1206280 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1206280 
> 
> Diff: http://svn.reviewboard.kde.org/r/6070/diff
> 
> 
> Testing
> -------
> 
> I tested the wizard in different situations and it doesn't let the user overwrite the existing maps. Also it warns the user properly if there is an invalid input.
> 
> 
> Screenshots
> -----------
> 
> Step One
>   http://svn.reviewboard.kde.org/r/6070/s/577/
> Step Two
>   http://svn.reviewboard.kde.org/r/6070/s/578/
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101214/6097b399/attachment.htm