[Marble-devel] Re: Review Request: Map Creation Wizard

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6070/#review9249
-----------------------------------------------------------

Ship it!


Congratulations for accomplishing this challenging task! I have just a few comments. :)


trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6070/#comment10115>

    This connecton should go into the constructor. Otherwise parseServerCapabilities() will be called n times, where n is the number of times the "Inspect" button was pressed.



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6070/#comment10116>

    "firstLayer" should have a better name. Perhaps "wmsReply"?



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6070/#comment10113>

    This connect statement should go into the constructor, too.


- Bernhard


On 2010-12-13 15:14:02, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6070/
> -----------------------------------------------------------
> 
> (Updated 2010-12-13 15:14:02)
> 
> 
> Review request for marble, Torsten Rahn and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> Map wizard helps users create a new map easily.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1202078 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1202078 
>   trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1202078 
>   trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui 1202078 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1202078 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1202078 
>   trunk/KDE/kdeedu/marble/src/marble.kcfg 1202078 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1202078 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1202078 
> 
> Diff: http://svn.reviewboard.kde.org/r/6070/diff
> 
> 
> Testing
> -------
> 
> I tested the wizard in different situations and it doesn't let the user overwrite the existing maps. Also it warns the user properly if there is an invalid input.
> 
> 
> Screenshots
> -----------
> 
> Step One
>   http://svn.reviewboard.kde.org/r/6070/s/577/
> Step Two
>   http://svn.reviewboard.kde.org/r/6070/s/578/
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101214/a233b1ed/attachment.htm